Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CronArchive: Catch UnexpectedWebsiteFoundException #14397

Closed
wants to merge 10 commits into from

Conversation

paladox
Copy link
Contributor

@paladox paladox commented May 1, 2019

This is to allow the archive to continue if the site was deleted from matomo.

Fixes #14393

@paladox
Copy link
Contributor Author

paladox commented May 1, 2019

ci failure seems unrelated.

Submodule path 'tests/travis': checked out 'f93beed1fcbc90be0e961e2883124651f463efae'
Failed to recurse into submodule path 'plugins/Morpheus/icons'
The command "eval git submodule update --init --recursive " failed. Retrying, 2 of 3.

@paladox
Copy link
Contributor Author

paladox commented May 1, 2019

I've tested this locally and seems to work (i correctly get a "Skipped website id 2946, got: UnexpectedWebsiteFoundException") where needed.

@tsteur
Copy link
Member

tsteur commented May 2, 2019

@paladox the PR needs to be made against 3.x-dev, not master

@paladox paladox changed the base branch from master to 3.x-dev May 2, 2019 11:06
@paladox
Copy link
Contributor Author

paladox commented May 2, 2019

done in #14403

@paladox paladox closed this May 2, 2019
@paladox paladox deleted the patch-1 branch May 2, 2019 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Let core:archive continue even if the website was deleted in the meantime
5 participants