Copy geoip archive into temporary folder instead of in the geoip folder #14380
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the geoip tar.gz archive is downloaded and extracted into the
misc
directory or whatever is configured eg through'path.geoip2' => DI\string('{path.root}/misc/geoip/'),
. However, only themisc/GeoLite2-City.mmdb
might have write access but not any other file. This causes the updating of the geodb to fail. Instead, it should be extracted into thetmp/latest
folder which we use for such cases (eg matomo update, plugin update, ...)