Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy geoip archive into temporary folder instead of in the geoip folder #14380

Merged
merged 5 commits into from May 13, 2019

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Apr 29, 2019

I noticed the geoip tar.gz archive is downloaded and extracted into the misc directory or whatever is configured eg through 'path.geoip2' => DI\string('{path.root}/misc/geoip/'),. However, only the misc/GeoLite2-City.mmdb might have write access but not any other file. This causes the updating of the geodb to fail. Instead, it should be extracted into the tmp/latest folder which we use for such cases (eg matomo update, plugin update, ...)

@tsteur tsteur added the Needs Review PRs that need a code review label Apr 29, 2019
@tsteur tsteur added this to the 3.10.0 milestone Apr 29, 2019
Copy link
Member

@diosmosis diosmosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, not sure if @sgiehl wants to take a look as well

I noticed the geoip tar.gz archive is downloaded  and extracted into the `misc` directory or whatever is configured eg through ` 'path.geoip2' => DI\string('{path.root}/misc/geoip/'),`. However, only the `misc/GeoLite2-City.mmdb` might have write access but not any other file. This causes the updating of the geodb to fail. Instead, it should be extracted into the `tmp/latest` folder which we use for such cases (eg matomo update, plugin update, ...)
@tsteur tsteur merged commit accdec4 into 3.x-dev May 13, 2019
@sgiehl sgiehl deleted the geoipdbarchive branch May 13, 2019 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants