Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure segment definitions don't regress #14372

Merged
merged 1 commit into from May 9, 2019
Merged

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Apr 25, 2019

fixes #14364

@sgiehl sgiehl force-pushed the fixsegmentdefinitions branch 5 times, most recently from 4e72fd3 to 9cbbf19 Compare April 25, 2019 20:43
@sgiehl sgiehl added the Needs Review PRs that need a code review label Apr 25, 2019
@sgiehl sgiehl added this to the 3.10.0 milestone Apr 25, 2019
@sgiehl
Copy link
Member Author

sgiehl commented Apr 25, 2019

@tsteur could you check if the changes are fixing the regression in CustomReports?

@tsteur
Copy link
Member

tsteur commented Apr 28, 2019

Works @sgiehl 👍 tests now succeed in custom reports

@tsteur
Copy link
Member

tsteur commented Apr 29, 2019

Only tests need to be updated, eg https://travis-ci.org/matomo-org/matomo/jobs/524659395#L1539

@sgiehl
Copy link
Member Author

sgiehl commented May 9, 2019

rebased the branch on latest changes to 3.x-dev. Tests are passing now... Guess should be good to merge?

@tsteur
Copy link
Member

tsteur commented May 9, 2019

Yes 👍

@sgiehl sgiehl merged commit a4c8dc9 into 3.x-dev May 9, 2019
@sgiehl sgiehl deleted the fixsegmentdefinitions branch May 9, 2019 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Readable segment values for browser causes regression in custom reports
2 participants