Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using image link in reporting menu if icon is not in font set. #14369

Closed
wants to merge 1 commit into from

Conversation

diosmosis
Copy link
Member

No description provided.

@diosmosis diosmosis added the Needs Review PRs that need a code review label Apr 23, 2019
@diosmosis diosmosis added this to the 3.10.0 milestone Apr 23, 2019
* A link to an image to use for this category, if the desired icon does not exist.
* @var string|null
*/
protected $imageUrl = null;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw we could include icon in matomo core or load a separate font for that icon (i think we used to do that in a/b testing in the beginning)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR seemed a bit less time consuming, but if this is something we don't want to support I can go an alternate route.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be nice to always use icons as they have higher res, color can be changed easily etc. It might be even easier to just add another icon to core? or embed a separate font?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the process for adding another icon? A readme would be helpful (I think it involves a PR to the icons repo, but not sure how the font is built.)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's described here: https://github.com/matomo-org/matomo/blob/3.x-dev/plugins/Morpheus/fonts/README.md basically you upload the selection.json, add new icons that you want, and export the font again. The updated font and selection.json is then put into the repo

@diosmosis diosmosis closed this Apr 24, 2019
@diosmosis diosmosis deleted the image-url-menu-icon branch April 24, 2019 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants