Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readable segment values for browser causes regression in custom reports #14364

Closed
tsteur opened this issue Apr 22, 2019 · 1 comment · Fixed by #14372
Closed

Readable segment values for browser causes regression in custom reports #14364

tsteur opened this issue Apr 22, 2019 · 1 comment · Fixed by #14372
Assignees
@sgiehl
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Milestone
3.10.0

Comments

@tsteur
Copy link
Member

tsteur commented Apr 22, 2019 •
edited

See https://github.com/matomo-org/matomo/pull/13929/files#diff-9b36d5d506002d73975c4f8486780ce5R23

The existing dimension should still use eg browserCode otherwise it will generates these segments that won't work and broke the API:
image

Adding not-in-changelog as the regression wasn't released. Ideally, browserCode is still defined in that dimension, and browserName in a new dimension.

fyi @sgiehl
@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels Apr 22, 2019
@tsteur tsteur added this to the 3.10.0 milestone Apr 22, 2019
@tsteur
Copy link
Member Author

tsteur commented Apr 22, 2019

image
same happens to countryName/countryCode

@sgiehl sgiehl self-assigned this Apr 25, 2019
@sgiehl sgiehl mentioned this issue Apr 25, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgiehl sgiehl

Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
3.10.0
Development

Successfully merging a pull request may close this issue.

Ensure segment definitions don't regress matomo-org/matomo
2 participants
@tsteur @sgiehl