Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in "Asking for Consent" JS code #14361

Merged
merged 2 commits into from Apr 19, 2019
Merged

Fix typo in "Asking for Consent" JS code #14361

merged 2 commits into from Apr 19, 2019

Conversation

mattab
Copy link
Member

@mattab mattab commented Apr 18, 2019

as reported by a user

@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Apr 18, 2019
@mattab mattab added this to the 3.10.0 milestone Apr 18, 2019
tsteur
tsteur approved these changes Apr 18, 2019
View reviewed changes
Copy link
Member

@tsteur tsteur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI test will probably need to be updated. Otherwise 👍

@sgiehl sgiehl merged commit dd5631d into 3.x-dev Apr 19, 2019
@sgiehl sgiehl deleted the typo_consent branch April 19, 2019 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsteur tsteur tsteur approved these changes

Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.10.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mattab @tsteur @sgiehl