New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker compose development environment #14354
Docker compose development environment #14354
Conversation
## How to submit code improvements via pull requests? | ||
|
||
You can help contribute to Matomo codebase via Pull Requests, see [Contributing to Matomo core](https://developer.matomo.org/guides/contributing-to-piwik-core) | ||
|
||
|
||
<a name="docker-based-development-environment"></a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we instead maybe simply link to our official docker? https://github.com/matomo-org/docker
I guess this should rather be a separate project or a part of https://github.com/matomo-org/docker than in the main repository. |
@dshiryaev-plesk I noticed you're thumbs down. I suppose we would be wanting max a link to our official docker but for sure not want to maintain another docker. There's also the problem that we would need to potentially maintain the SQL fixture over time etc and having this in this repository doesn't quite work for us as we wouldn't even really be able to support and maintain it. Might be better to put it in a standalone repository? |
@tsteur what do you reckon we do here? |
I still think that this shouldn't be in the main repo as it means that it needs to be maintained together with Matomo itself. (and having an SQL file in Matomo means people take it as official and will complain once it doesn't work)
@J0WI What's your opinion? |
Definitely wouldn't merge in this repo. |
I think it's the best to just use |
Closing this issue for now as we agreed we don't really want to have this in core. @dshiryaev-plesk maybe look at the last comments re what could be done? |
Hello,
See CONTRIBUTING.md for documentation.
Benefits of Docker development environment for Matomo at Matomo source code: