Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker compose development environment #14354

Conversation

dshiryaev-plesk
Copy link

@dshiryaev-plesk dshiryaev-plesk commented Apr 17, 2019

Hello,
See CONTRIBUTING.md for documentation.

Benefits of Docker development environment for Matomo at Matomo source code:

  • quick start for Matomo developers
    • no deployment and configuration of required versions of MySQL, PHP, web server
    • no configuration of Matomo, it's already configured
    • similar approach for all projects that use Docker Compose as a development environment: setup Docker, Docker Compose once for all projects that use Docker Compose, then run docker-compose up in directory of project source code
  • Matomo developers can work simultaneously with different projects that have different system requirements or with different Matomo versions, since the system environment is in Docker images and small dump of Matomo database for Docker development environment is in the source code of Matomo
  • all Matomo developers can work with the same system environment in bounds of one version Matomo, since the system environment is in Docker images

## How to submit code improvements via pull requests?

You can help contribute to Matomo codebase via Pull Requests, see [Contributing to Matomo core](https://developer.matomo.org/guides/contributing-to-piwik-core)


<a name="docker-based-development-environment"></a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we instead maybe simply link to our official docker? https://github.com/matomo-org/docker

@Findus23
Copy link
Member

I guess this should rather be a separate project or a part of https://github.com/matomo-org/docker than in the main repository.

@tsteur
Copy link
Member

tsteur commented May 3, 2019

@dshiryaev-plesk I noticed you're thumbs down. I suppose we would be wanting max a link to our official docker but for sure not want to maintain another docker. There's also the problem that we would need to potentially maintain the SQL fixture over time etc and having this in this repository doesn't quite work for us as we wouldn't even really be able to support and maintain it. Might be better to put it in a standalone repository?

@mattab
Copy link
Member

mattab commented Jun 10, 2019

@tsteur what do you reckon we do here?
@dshiryaev-plesk any thoughts?

@Findus23
Copy link
Member

I still think that this shouldn't be in the main repo as it means that it needs to be maintained together with Matomo itself. (and having an SQL file in Matomo means people take it as official and will complain once it doesn't work)
I'm proposing:

@J0WI What's your opinion?

@tsteur
Copy link
Member

tsteur commented Jun 10, 2019

Definitely wouldn't merge in this repo.

@J0WI
Copy link

J0WI commented Jun 10, 2019

I think it's the best to just use FROM matomo and add whatever you need for development. We should not add xdebug to https://github.com/matomo-org/docker and definitely not on DockerHub.
A minimal docker-compose.yml example could also be added to https://github.com/docker-library/docs/tree/master/matomo, but the example here is far more complex than what is required to play with this container.

@tsteur
Copy link
Member

tsteur commented Jun 19, 2019

Closing this issue for now as we agreed we don't really want to have this in core. @dshiryaev-plesk maybe look at the last comments re what could be done?

@tsteur tsteur closed this Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants