Permit segmenting by order ID #14316
Conversation
diosmosis
added
the
not-in-changelog
plugins/Ecommerce/Columns/Order.php
Outdated
|
|
||
| public function configureMetrics(MetricsList $metricsList, DimensionMetricFactory $dimensionMetricFactory) | ||
| { | ||
| $metric = $dimensionMetricFactory->createMetric(ArchivedMetric::AGGREGATION_UNIQUE); | ||
| $metric->setName("ecommerce_order_id"); |
There was a problem hiding this comment.
@katebutler do you remember if the name was needed? Changing the name of existing metrics may break existing custom reports that have the old metricId assigned.
There was a problem hiding this comment.
@tsteur Turns out it's not needed, have removed it
|
Left a comment, otherwise worked for me. 👍 |
|
@katebutler this test seems to fail: https://travis-ci.org/matomo-org/matomo/jobs/517626504#L832 this one too which is maybe related to the order that we are now tracking and should be an expected change I reckon: https://travis-ci.org/matomo-org/matomo/jobs/517626504#L811 The UI tests stopped running in the middle of the test. Restarted the tests and hoping it completes. I suppose there might be a few screenshot tests to update. Can show you tomorrow how to do it. Seems otherwise good to merge except for the tests that need to be updated. |
|
@katebutler just fyi here's a test that needs to be fixed: https://travis-ci.org/matomo-org/matomo/jobs/517626504#L811-L825 The test fails now correctly and we only need to update the values |
Fixes #9981