@ddrjm opened this Issue on April 2nd 2019

Before upgrading I had a couple of template overrides inside a custom theme as stated here:
https://developer.matomo.org/guides/theming#twig-the-template-engine

After the 3.9.1 upgrade, the templates are no longer being loaded.
I have manually reverted this section in my installation
https://github.com/matomo-org/matomo/pull/14051/files#diff-55e7eb22dafce9c6bf9d3fc98022f2ebL547
and the overrides started working again.

After a few var_dumps I found out that the new code just loops across all folders and doesn't consider the theme folder to search there.

Aside from the custom theme generated by the console that only overrides colors and a adds a couple of static html to some visualization templates, the installation is clean.

@tsteur commented on April 7th 2019 Member

Does your plugin have a plugin.json file?

@ddrjm commented on April 8th 2019

Does your plugin have a plugin.json file?

Yes. It is a theme generated by the console.

@tsteur commented on April 8th 2019 Member

Any chance you can point us to the GitHub repo or send the code to hello at matomo.org ? we can't reproduce the issue.

@ddrjm commented on April 10th 2019

@tsteur Sent the theme files via email.

@tsteur commented on April 10th 2019 Member

Thanks a lot! We were able to reproduce it and fixed it in https://github.com/matomo-org/matomo/pull/14337

This Issue was closed on April 11th 2019
Powered by GitHub Issue Mirror