Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing build #14296

Merged
merged 7 commits into from Mar 31, 2019
Merged

Fixing build #14296

merged 7 commits into from Mar 31, 2019

Conversation

diosmosis
Copy link
Member

@diosmosis diosmosis commented Mar 31, 2019 •
edited

Includes fix to logging, NullHandler (which was added to fix issue w/ Monolog when handlers array is empty) stops bubbling, so keeping it as the first handler can stop logging.

Fixes #14289

@diosmosis diosmosis added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Mar 31, 2019
@diosmosis diosmosis added this to the 3.10.0 milestone Mar 31, 2019
@diosmosis diosmosis merged commit f2d44ef into 3.x-dev Mar 31, 2019
@diosmosis diosmosis deleted the xss-test branch March 31, 2019 23:53
@Findus23 Findus23 mentioned this pull request Apr 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.10.0
Development

Successfully merging this pull request may close these issues.

Always false condition
1 participant
@diosmosis