Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer-izing libs/ #14291

Closed
szepeviktor opened this issue Mar 30, 2019 · 6 comments
Closed

Composer-izing libs/ #14291

szepeviktor opened this issue Mar 30, 2019 · 6 comments
Labels
answered For when a question was asked and we referred to forum or answered it.

Comments

@szepeviktor
Copy link
Contributor

szepeviktor commented Mar 30, 2019

Are there plans to clean up libs/* and use modern composer packages instead?

@fdellwing
Copy link
Contributor

Matomo already uses composer.

@szepeviktor
Copy link
Contributor Author

Thanks.

Are there plans to remove all libs and use only composer packages?

@fdellwing
Copy link
Contributor

Yes: #14082

@tsteur
Copy link
Member

tsteur commented Mar 30, 2019

Are there plans to remove all libs and use only composer packages?

Are there any particular reasons why?

@szepeviktor
Copy link
Contributor Author

szepeviktor commented Mar 30, 2019

I've started analyzing Matomo with PHPStan in #14290 and those libs are old and poorly written code, had to exclude all of them from testing.

@tsteur
Copy link
Member

tsteur commented Mar 30, 2019

Will close the issue. We're not going to update / change any libraries unless we have new feature requirements that require a new library if requirements can't be met by a current lib or unless they have security issues or so. We don't just update libs though just because of poorly written code or because they are old (old doesn't mean bad) when things work in general. If you find a lib that has a minor version update (same major version) and is available in NPM feel free to issue a PR and we will review over time.

Cheers

@tsteur tsteur closed this as completed Mar 30, 2019
@tsteur tsteur added the answered For when a question was asked and we referred to forum or answered it. label Mar 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
answered For when a question was asked and we referred to forum or answered it.
Projects
None yet
Development

No branches or pull requests

3 participants