Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a config to disable e-mail notifications on password/email change through API #14281

Merged
merged 6 commits into from Apr 11, 2019

Conversation

simivar
Copy link
Contributor

@simivar simivar commented Mar 28, 2019

Adds a new config option api_update_users_email_notifications that when set to 0 disables all emails from UserManager::updateUser API endpoint. #14267

@simivar simivar changed the title Add a config to disable e-mail notifications on password/email change through API #14267 Add a config to disable e-mail notifications on password/email change through API Mar 28, 2019
@Findus23 Findus23 added the Needs Review PRs that need a code review label Mar 29, 2019
@diosmosis diosmosis added this to the 3.10.0 milestone Apr 1, 2019
@diosmosis
Copy link
Member

@simivar
Copy link
Contributor Author

simivar commented Apr 2, 2019

@diosmosis done in 7a5ece1

@simivar
Copy link
Contributor Author

simivar commented Apr 3, 2019

@diosmosis I was thinking... wouldn't it be better to move in .ini file api_update_users_email_notifications from General settings to its own [api] and name it update_users_email_notifications?

@diosmosis
Copy link
Member

I don't think where the config is located in the INI file is all that important, as long as it's not outright inaccurate. Maybe @tsteur or @mattab has another opinion

@tsteur
Copy link
Member

tsteur commented Apr 3, 2019

@simivar the issue is already assigned to @katebutler and I think some work had already been done there. @katebutler did you push some code for #14267 already? @simivar be good to check if an issue is maybe already assigned to someone which means they are working on it already.

Re the name: It's not too important and actually the current implementation would also disable it for the UI I think.

@tsteur tsteur merged commit 4566c44 into matomo-org:3.x-dev Apr 11, 2019
@tsteur
Copy link
Member

tsteur commented Apr 11, 2019

Cheers for this @simivar

@mattab mattab added the Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. label Jun 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants