@simivar opened this Pull Request on March 28th 2019 Contributor

Adds a new config option api_update_users_email_notifications that when set to 0 disables all emails from UserManager::updateUser API endpoint. #14267

@diosmosis commented on April 1st 2019 Member
@simivar commented on April 2nd 2019 Contributor

@diosmosis done in 7a5ece1

@simivar commented on April 3rd 2019 Contributor

@diosmosis I was thinking... wouldn't it be better to move in .ini file api_update_users_email_notifications from General settings to its own [api] and name it update_users_email_notifications?

@diosmosis commented on April 3rd 2019 Member

I don't think where the config is located in the INI file is all that important, as long as it's not outright inaccurate. Maybe @tsteur or @mattab has another opinion

@tsteur commented on April 3rd 2019 Member

@simivar the issue is already assigned to @katebutler and I think some work had already been done there. @katebutler did you push some code for #14267 already? @simivar be good to check if an issue is maybe already assigned to someone which means they are working on it already.

Re the name: It's not too important and actually the current implementation would also disable it for the UI I think.

@tsteur commented on April 11th 2019 Member

Cheers for this @simivar

This Pull Request was closed on April 11th 2019
Powered by GitHub Issue Mirror