New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overwrite direct entry referrer information if campaign referrer is found in later request. #14273
Conversation
…ound in later request.
Feedback:
|
@mattab Is |
example.com would be the main URL (or even alias URL) but which wasn't specified in Website URLs field. |
@mattab I see there's no required main URL field anymore. So you mean to add |
Looks good to me (quick look). Looking forward to the tests 👍 |
Added integration tests, system tests will need to be fixed, ready for a review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- be great to also update any other system tests impacted by this and check they are not regression
Noticed in one user's logs, the campaign information came in the second request. @mattab suggested that direct entry referrers should be overwritten by campaign information if supplied in a later request.