@diosmosis opened this Pull Request on March 26th 2019 Member

Noticed in one user's logs, the campaign information came in the second request. @mattab suggested that direct entry referrers should be overwritten by campaign information if supplied in a later request.

@mattab commented on March 26th 2019 Member

Feedback:

@diosmosis commented on March 26th 2019 Member

@mattab Is example.com the main URL for the site? Or an alias URL?

@mattab commented on March 27th 2019 Member

example.com would be the main URL (or even alias URL) but which wasn't specified in Website URLs field.

@diosmosis commented on March 27th 2019 Member

@mattab I see there's no required main URL field anymore. So you mean to add hostname(url) to the list of website URLs, makes sense.

@mattab commented on March 28th 2019 Member

Looks good to me (quick look). Looking forward to the tests :+1:

@diosmosis commented on March 29th 2019 Member

Added integration tests, system tests will need to be fixed, ready for a review.

This Pull Request was closed on May 10th 2019
Powered by GitHub Issue Mirror