@Findus23 opened this Pull Request on March 24th 2019 Member

This is a WIP to delete old files in misc/ that don't work or are not needed anymore.
It also updates the GPL file to the latest version from https://www.gnu.org/licenses/gpl.txt

If someone needs those files or knows where they are still referenced or knows more files that can be deleted, comment here.

It would also maybe be useful to write an update script that deletes these files so that everyone doesn't need to delete them manually.

@tsteur commented on April 11th 2019 Member

Looks good to me. Not sure if @mattab has any thoughts. But better to have those docs rather in our guides etc.

It would also maybe be useful to write an update script that deletes these files so that everyone doesn't need to delete them manually.

They should be automatically deleted or not? See plugins/CoreUpdater/Model.php::removeGoneFiles

@mattab commented on April 11th 2019 Member

LGTM :+1:

@Findus23 commented on May 17th 2019 Member

@tsteur I just updated my instance to the beta2 and the files are still there and integrity checker is complaining about them as I expected.

Is it possible that this isn't working as it should?

@tsteur commented on May 28th 2019 Member

Seems we don't apply this to the misc directory. Probably because there may be many user directories/ user files such as brand logos, config files, tracker files, ... https://github.com/matomo-org/matomo/blob/3.10.0-b3/plugins/CoreUpdater/Model.php#L28-L30

This Pull Request was closed on April 11th 2019
Powered by GitHub Issue Mirror