Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc/ cleanup #14265

Merged
merged 2 commits into from Apr 11, 2019
Merged

misc/ cleanup #14265

merged 2 commits into from Apr 11, 2019

Conversation

Findus23
Copy link
Member

This is a WIP to delete old files in misc/ that don't work or are not needed anymore.
It also updates the GPL file to the latest version from https://www.gnu.org/licenses/gpl.txt

If someone needs those files or knows where they are still referenced or knows more files that can be deleted, comment here.

It would also maybe be useful to write an update script that deletes these files so that everyone doesn't need to delete them manually.

@Findus23 Findus23 added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Mar 24, 2019
@tsteur
Copy link
Member

tsteur commented Apr 11, 2019

Looks good to me. Not sure if @mattab has any thoughts. But better to have those docs rather in our guides etc.

It would also maybe be useful to write an update script that deletes these files so that everyone doesn't need to delete them manually.

They should be automatically deleted or not? See plugins/CoreUpdater/Model.php::removeGoneFiles

@mattab mattab added this to the 3.10.0 milestone Apr 11, 2019
@mattab
Copy link
Member

mattab commented Apr 11, 2019

LGTM 👍

@tsteur tsteur marked this pull request as ready for review April 11, 2019 20:59
@tsteur tsteur merged commit 5ed0908 into 3.x-dev Apr 11, 2019
@tsteur tsteur deleted the cleanup-misc branch April 11, 2019 20:59
@Findus23
Copy link
Member Author

@tsteur I just updated my instance to the beta2 and the files are still there and integrity checker is complaining about them as I expected.

Is it possible that this isn't working as it should?

@tsteur
Copy link
Member

tsteur commented May 28, 2019

Seems we don't apply this to the misc directory. Probably because there may be many user directories/ user files such as brand logos, config files, tracker files, ... https://github.com/matomo-org/matomo/blob/3.10.0-b3/plugins/CoreUpdater/Model.php#L28-L30

@sgiehl sgiehl mentioned this pull request Jul 1, 2019
Closed
@Findus23 Findus23 restored the cleanup-misc branch October 4, 2019 09:49
@sgiehl sgiehl deleted the cleanup-misc branch February 10, 2020 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsteur tsteur tsteur approved these changes

Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.10.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Findus23 @tsteur @mattab