Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing session name with const PIWIK_SESSION_NAME not possible #14254

Closed
shenziro opened this issue Mar 22, 2019 · 2 comments · Fixed by #14283
Closed

Changing session name with const PIWIK_SESSION_NAME not possible #14254

shenziro opened this issue Mar 22, 2019 · 2 comments · Fixed by #14283
Labels
Regression Indicates a feature used to work in a certain way but it no longer does even though it should.

Comments

@shenziro
Copy link

According to https://matomo.org/docs/include-piwik-in-your-project/#bootstrap-php-execute-custom-code-before-matomo-runs the session name can be configured by setting the constant "PIWIK_SESSION_NAME".

This is not (longer?) possible. Tested with 3.9 and 3.9.1.

It seems that the session name is hardcoded in core/Session.php. I found no variable or constant to change it without fiddling around with the Session.php file and loosing my changes on every update.
@simivar
Copy link
Contributor

simivar commented Mar 28, 2019

It was removed back in 2014 by @mattab in 3ce2344.

@mattab could you please provide some context why it was removed and if it can/should be restored?

@mattab
Copy link
Member

mattab commented Mar 28, 2019

It is a bug I introduced I believe. @shenziro @simivar please feel free to open a PR to fix this issue again and we will merge it (since it is a documented feature). Thanks 👍

@simivar simivar mentioned this issue Mar 28, 2019
Merged
diosmosis pushed a commit that referenced this issue Apr 1, 2019
@simivar @diosmosis
Changing session name with const PIWIK_SESSION_NAME (#14254) (#14283)
480ebd8
@mattab mattab added the Regression Indicates a feature used to work in a certain way but it no longer does even though it should. label Jun 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Changing session name with const PIWIK_SESSION_NAME (#14254)
3 participants
@mattab @shenziro @simivar