Currently we delete this metric "because it could differ from the sum of each goal conversions", but it should, since nb_visits_converted is not the sum of each goal's conversions. Conversions can happen multiple times per visit, so this would not be accurate.
Also, it is not the sum of each goals' nb_visits_converted, since visits can share conversions for different goals. Keeping it puts the correct value of conversion_rate in scheduled reports.
Moving to 3.11 since it's not a straightforward fix
@mattab removed the code you were talking about (that was for showing the conversion rate for old reports, but of course that won't work).
From testing manually and looking at automated tests, the nb_visits_converted metric that's not in the
goals array looks accurate. It's computed by
queryVisitsByDimension() which aggregates over the log_visit table, so I'm not sure why it would be inaccurate. Don't think there's an issue in keeping it.
(tests need updated before merge)
Some tests are still failing @diosmosis . Feel free to merge once the build is green