Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose including unlink into upgrade process #14249

Closed
fdellwing opened this issue Mar 20, 2019 · 2 comments
Closed

Propose including unlink into upgrade process #14249

fdellwing opened this issue Mar 20, 2019 · 2 comments
Labels
duplicate For issues that already existed in our issue tracker and were reported previously.

Comments

@fdellwing
Copy link
Contributor

fdellwing commented Mar 20, 2019

Currently files that are no longer needed after an update will be shown in integrety report to be deleted by the user. This does confuse some people and I do understand that feeling. I also think after an update there should be no unwated files in my install folder that I did not put there myself.

I propose that with the following version the update process unlinks all files that are deleted from one to another version. With 3.8.1 -> 3.9.0 this would have been:

plugins/Referrers/Widgets/GetKeywordsForPage.php
vendor/JShrink/

Probably this would also need a new helper function as PHP is not able to delete folders with content, so we have to unlink everything recursivly and finally call rmdir on the folder.

@Findus23
Copy link
Member

Duplicate of #11132 🙂

Doing this automatically sounds like something where a lot of things can go dangerously wrong.

So at most I'd go with a button that deletes all files listed above.

@Findus23 Findus23 added the duplicate For issues that already existed in our issue tracker and were reported previously. label Mar 20, 2019
@fdellwing
Copy link
Contributor Author

I don't see a big risk for much going wrong as I would not integrate this into the integrety report but write it by hand in the core/Updates/xxx.php. Will continue in orginal issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate For issues that already existed in our issue tracker and were reported previously.
Projects
None yet
Development

No branches or pull requests

2 participants