Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not send password changed email for automated use cases. #14240

Merged
merged 1 commit into from Mar 20, 2019

Conversation

diosmosis
Copy link
Member

@diosmosis diosmosis commented Mar 19, 2019

Fixes matomo-org/plugin-LoginLdap#180

Updated since previous solution wouldn't work.

@diosmosis diosmosis changed the title Only send password changed email if new password is different from old. Do not send password changed email for automated use cases. Mar 19, 2019
@@ -922,7 +922,9 @@ public function updateUser($userLogin, $password = false, $email = false, $alias
$this->sendEmailChangedEmail($userInfo, $email);
}

if ($passwordHasBeenUpdated) {
if ($passwordHasBeenUpdated
&& $requirePasswordConfirmation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not tested but looks good 👍

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch tested and no e-mail is sent after login with a ldap account.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jgkirschbaum thx for confirmation

@sgiehl sgiehl added this to the 3.9.1 milestone Mar 20, 2019
@sgiehl sgiehl merged commit 4df7874 into 3.x-dev Mar 20, 2019
@sgiehl sgiehl deleted the set-same-pwd branch March 20, 2019 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants