Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure Monolog never adds its default handler. #14239

Merged
merged 1 commit into from Mar 20, 2019
Merged

Make sure Monolog never adds its default handler. #14239

merged 1 commit into from Mar 20, 2019

Conversation

diosmosis
Copy link
Member

Fixes #14229

This issue was always around, but exposed probably by https://github.com/matomo-org/matomo/blob/3.x-dev/plugins/Monolog/config/config.php#L42-L44, which results in an empty handlers array. Causing the following code in Monolog to be executed:

        if (!$this->handlers) {
            $this->pushHandler(new StreamHandler('php://stderr', static::DEBUG));
        }

Which resulted in climulti requests always having debug level output.

Note: this code doesn't appear to be in the latest monolog version.

@diosmosis diosmosis added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Mar 19, 2019
@diosmosis diosmosis mentioned this pull request Mar 19, 2019
Closed
@sgiehl sgiehl added this to the 3.9.1 milestone Mar 20, 2019
@sgiehl sgiehl merged commit 54e87e5 into 3.x-dev Mar 20, 2019
@sgiehl sgiehl deleted the monolog-core-archive branch March 20, 2019 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.9.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@diosmosis @sgiehl