Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use mb_substr wrapper method #14231

Merged
merged 1 commit into from Mar 20, 2019
Merged

use mb_substr wrapper method #14231

merged 1 commit into from Mar 20, 2019

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Mar 19, 2019 •
edited

might otherwise cause problems if mbstring extensions is not installed

This was reported multiple times by mail

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Mar 19, 2019
@sgiehl sgiehl added this to the 3.10.0 milestone Mar 19, 2019
@sgiehl sgiehl merged commit 2ec7485 into 3.x-dev Mar 20, 2019
@sgiehl sgiehl deleted the mbstrwrapper branch March 20, 2019 09:39
@sgiehl sgiehl modified the milestones: 3.10.0, 3.9.1 Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsteur tsteur tsteur approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.9.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sgiehl @tsteur