Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make theme-color themeable #14230

Closed
Findus23 opened this issue Mar 19, 2019 · 1 comment · Fixed by #14282
Closed

Make theme-color themeable #14230

Findus23 opened this issue Mar 19, 2019 · 1 comment · Fixed by #14282
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Milestone
Backlog (Help wan...

Comments

@Findus23
Copy link
Member

Many people theme their Matomo instance to be more on brand, but when the main navbar color is changed, mobile phones still show the default blue color as it is hard-coded here:

matomo/plugins/Morpheus/templates/layout.twig

Line 25 in cb54533

<meta name="theme-color" content="#3450A3">

It would be great if there was a way to modify this value without copying the whole template (which may cause issues after updates)
@Findus23 Findus23 added the c: Design / UI For issues that impact Matomo's user interface or the design overall. label Mar 19, 2019
@tsteur tsteur added this to the Backlog (Help wanted) milestone Mar 19, 2019
@tsteur tsteur added the Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. label Mar 19, 2019
@simivar simivar mentioned this issue Mar 28, 2019
Merged
@simivar
Copy link
Contributor

simivar commented Mar 28, 2019

@Findus23 I've created a PR but the only way to do it I came up with is loading whole ThemeStyles into View object. Maybe you see other option?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Projects
None yet
Milestone
Backlog (Help wanted)
Development

Successfully merging a pull request may close this issue.

Load ThemeStyles in View and make theme-color themeable
3 participants
@tsteur @simivar @Findus23