Ensure first sparkline is highlighted after switching periods in row evolution overlay #14212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
c: Design / UI
|
As far as I can tell, this doesn't actually fix the bug, right? If I click on Unique Visitors, for example, it will still show the actions series:
Not sure what this PR is supposed to fix? |
|
that PR only fixes a highlight issue, When you choose to display not the first metric and switch the periods all metric sparklines will be not highlighted afterwards. With this PR the first sparkline should be highlighted again |
diosmosis
approved these changes
Mar 26, 2019
|
I see, looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When switching the periods in the evolution chart in the row evolution overlay, the selected metrics are unset. If another metric than the first one was selected at this point, no metric is highlighted in the sparkline list below afterwards.
Note: This is just a quick fix for the current behavior. Imho it would be a lot better to actually restore the selected metrics when switching the period
refs #14208