Display a warning if using an EOL version of PHP #14201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diosmosis
added
not-in-changelog
diosmosis
approved these changes
Mar 17, 2019
simivar
suggested changes
Mar 29, 2019
| @@ -207,7 +207,7 @@ private static function notifyIfEAcceleratorIsUsed() | |||
| */ | |||
| private static function getNextRequiredMinimumPHP() | |||
| { | |||
| return '5.5.9'; | |||
| return '7.1'; | |||
There was a problem hiding this comment.
Wouldn't it be better to move this to const and use it in line 371 as well?
| @@ -365,8 +366,8 @@ protected static function getPiwikVersion() | |||
| return "Matomo " . Version::VERSION; | |||
| } | |||
|
|
|||
| private static function isPhpVersionAtLeast55() | |||
| private static function isPhpVersionAtLeast71() | |||
There was a problem hiding this comment.
What do you think about renaming that method to isMinimalSupportedPhpVersion() or something along this line? There will be no need to rename it in the future.
tsteur
approved these changes
Mar 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warn the user if their version of PHP is < 7.1
Fixes #14174