Use tabular-nums in tables #14193
Merged
Use tabular-nums in tables #14193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good 👍 |
|
Nice improvement, thanks for the PR! @c960657 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Numeric data in tables look “jumpy” when using a font where digits have different widths. Using the tabular-nums font variant gets around this problem.
Without tabular-nums (with some gridlines added)
With tabular-nums
The above screenshots are made on MacOS.
This change does not to affect the screenshots made by Phantomjs on Travis, i.e. it seems that the the digits in the font used by Phantomjs all have equal width even without using tabular-nums.