New dimension for segmenting visitors by fingerprint #14184
Conversation
…rprint in getLastVisitsDetails API response
# Conflicts: # tests/PHPUnit/System/expected/test_OneVisitor_NoKeywordSpecified__Live.getLastVisitsDetails_day.xml
diosmosis
added
Needs Review
| { | ||
| $metric = $dimensionMetricFactory->createMetric(ArchivedMetric::AGGREGATION_UNIQUE); | ||
| $metric->setTranslatedName(Piwik::translate('Visitor_Fingerprint')); | ||
| $metric->setName('nb_uniq_visitors_fingerprint'); |
There was a problem hiding this comment.
Would we still need this call if we set $metricId to 'visitors_fingerprint'?
There was a problem hiding this comment.
When you set visitors_fingerprint as segment name, then the autosuggest doesn't work automatically anymore.
There was a problem hiding this comment.
I meant as $metricId, not $segmentName, unless they are related? Not sure I've ever used this API before... :)
There was a problem hiding this comment.
setting $metricId to visitors_fingerprint might be a good idea @katebutler 👍 . Shouldn't really change much though. In general the code in that method likely will still be needed to ensure only the unique fingerprint metrics is being created.
There was a problem hiding this comment.
Hi @katebutler, could you please respond to this thread (either by applying the requested change or commenting on why you'd rather not)? Once the thread is resolved I can merge this.
# Conflicts: # plugins/CoreConsole/tests/System/expected/test_ArchiveCronTest_preArchivedSegment1_noOptions__Live.getLastVisitsDetails_year.xml # tests/PHPUnit/System/expected/test_csvExport__Live.getLastVisitsDetails_day.csv
mattab
removed
the
not-in-changelog
Fixes #14101