Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In core:invalidate-report-data add support for invalidating date range #14178

Closed
mattab opened this issue Mar 11, 2019 · 1 comment · Fixed by #14450
Closed

In core:invalidate-report-data add support for invalidating date range #14178

mattab opened this issue Mar 11, 2019 · 1 comment · Fixed by #14450
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone
4.0.0

Comments

@mattab
Copy link
Member

mattab commented Mar 11, 2019 •
edited

Currently for some reason, core:invalidate-report-data command does not support invalidating date range reports.

As a user, when I use the GDPR controls to delete some visitor data, or in general whenever I delete some wrong data and then I invalidate reports, I'd expect (and need) all reports to be fully invalidated. Currently, "range" reports are not invalidated. So my range reports will still show old data while all others (day, week, month, years) work fine as expected.

The code where it is done: https://github.com/matomo-org/matomo/blob/3.9.0-b3/plugins/CoreAdminHome/Commands/InvalidateReportData.php#L126

  • Was there some reason it is disabled?
  • When calling core:invalidate-report-data without a --periods parameter, it would also automatically invalidate range. This would also 'just work' in the Invalidate Reports plugin

Would be valuable to implement this feature as it would make the feature fully work and not cause people confusion.
@mattab mattab added the Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. label Mar 11, 2019
@mattab mattab added this to the 3.11.0 milestone Mar 11, 2019
@katebutler katebutler mentioned this issue May 15, 2019
Merged
@mattab
Copy link
Member Author

mattab commented May 16, 2019

Note: as discussed, when we invalidate a date range, we just want to invalidate this exact date range specified. We figured it is not really do-able or needed to invalidate other date ranges which may partially overlap this one.

@tsteur tsteur modified the milestones: 3.13.0, 4.1.0 Jul 31, 2019
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Oct 25, 2019
@mattab mattab mentioned this issue Jan 23, 2020
Open
@mattab mattab modified the milestones: 4.1.0, 4.0.0 Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
4.0.0
Development

Successfully merging a pull request may close this issue.

Allow date ranges to be passed to core:invalidate-report-data matomo-org/matomo
2 participants
@tsteur @mattab