fix diagnostics template #14171
Merged
fix diagnostics template #14171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would displaying the value as json be helpful? |
|
Showing it json encoded sounds good 👍 |
|
@Findus23 should we maybe show it as json? or prefer current logic? |
Findus23
force-pushed
the
fix-config-twig-template
branch
from
4b47dac
to
cb5f2a4
Compare
|
Sorry, I missed this PR. I didn't think about JSON when creating the fix, this way it is easier and prettier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been seeing this error quite often on my instance in Sentry
It seems to be caused by my CustomiseTranslations plugin. Because when you are viewing the "Config File" Diagnostic page it tries to display the following data (as the plugin stores a list of dictionaries in the config)
[{$$hashKey: object:457, translationKey: CorePluginsAdmin_PluginsManagement, translationText: This is text!!}, {$$hashKey: object:467, translationKey: , translationText: }]My fix isn't great and I can't promise it works well, but maybe someone else can think of something more simple.