@fdellwing opened this Pull Request on March 1st 2019 Contributor

While doing another PR I noticed that the indentation in the stylesheets is really bad. I run stylelint with autofix enabled against it and this is the result. There are still some things that it doesn't like, but that are mostly order of selector related issues.

Please test the changes locally to make sure everything still works.

I used the following config: https://github.com/stylelint/stylelint-config-standard

Extends stylelint-config-recommended.

Turns on additional rules to enforce the common stylistic conventions found within a handful of CSS styleguides, including: The Idiomatic CSS Principles, Google's CSS Style Guide, Airbnb's Styleguide, and @mdo's Code Guide.

It favours flexibility over strictness for things like multi-line lists and single-line rulesets, and tries to avoid potentially divisive rules.

@fdellwing commented on March 12th 2019 Contributor

You can do this yourself very easily:

Install stylelint and stylelint-config-standard:

npm install -g stylelint
npm install -g stylelint-config-standard

Run find plugins/Morpheus/stylesheets/ -type f -regextype posix-extended -regex '.*.(css|less|sass)' -exec stylelint --config "/usr/lib/node_modules/stylelint-config-standard" {} --fix \; in your Matomo base dir.

@tsteur commented on April 11th 2019 Member

@fdellwing there's a merge conflict where I wasn't 100% sure how to resolve it. Could you resolve the conflict and then we can merge?

Cheers for this 👍

@fdellwing commented on April 11th 2019 Contributor

Let's see how it looks like after the latest changes, should not change much.

@fdellwing commented on April 11th 2019 Contributor

UI failures seem unrelated to me, but there are a lot of them.

This should be probably be looked at outside of this PR: https://builds-artifacts.matomo.org/matomo-org/matomo/3.x-dev/33656/Overlay_framed_loaded.png

@tsteur commented on April 11th 2019 Member

Thanks @fdellwing

Looked good on my local instance 👍

This Pull Request was closed on April 11th 2019
Powered by GitHub Issue Mirror