Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spellcheck en.json files #14135

Merged
merged 5 commits into from Apr 2, 2019
Merged

spellcheck en.json files #14135

merged 5 commits into from Apr 2, 2019

Conversation

Findus23
Copy link
Member

As the en.json files are not checked that often, I quickly went through all files with my spellchecker.

Some of the changes are a bit opinionated, so it would be great if someone could quickly read over them.

⚠️ As this changes some essential strings and therefore will invalidate the translations (or are they only invalidated on key changes?), this shouldn't be merged shortly before a release.

@Findus23 Findus23 added the Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. label Feb 25, 2019
@sgiehl
Copy link
Member

sgiehl commented Feb 27, 2019

@Findus23 removed your last commit as it was apparently on the wrong branch

Copy link

@katebutler katebutler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Findus23, most of this looks good, but I've suggested a couple of changes.

plugins/Insights/lang/en.json Outdated Show resolved Hide resolved
plugins/Installation/lang/en.json Outdated Show resolved Hide resolved
plugins/PrivacyManager/lang/en.json Outdated Show resolved Hide resolved
@sgiehl sgiehl added this to the 3.10.0 milestone Mar 11, 2019
@mattab mattab modified the milestones: 3.11.0, 3.10.0 Mar 19, 2019
@diosmosis diosmosis merged commit 7172c71 into 3.x-dev Apr 2, 2019
@diosmosis diosmosis deleted the spellcheck-en branch April 2, 2019 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants