@pimlottc-gov opened this Pull Request on February 22nd 2019 Contributor

Fixes #14100

@tsteur commented on April 11th 2019 Member

Cheers for this @pimlottc-gov Left a few comments.

Ideally you also generate the up to date minified version see https://github.com/matomo-org/matomo/tree/3.x-dev/js#deployment and add an entry to the developer changelog but I suppose we could do this as well.

@pimlottc-gov commented on April 16th 2019 Contributor

Ideally you also generate the up to date minified version see https://github.com/matomo-org/matomo/tree/3.x-dev/js#deployment and add an entry to the developer changelog but I suppose we could do this as well.

Thanks for the instructions, I went ahead and added a minified build. I'm not sure, though, which changelog to update?

@tsteur commented on April 17th 2019 Member

I've added the changelog entry and potentially fixed a test which doesn't liked a newline at the end. Will keep an eye on whether tests pass. Cheers for this 👍

@tsteur commented on April 17th 2019 Member

Cheers @pimlottc-gov for this PR 👍

This Pull Request was closed on April 17th 2019
Powered by GitHub Issue Mirror