Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display useful error message when embedding the whole app as iframe using Widgetize #14126

Closed
mattab opened this issue Feb 21, 2019 · 4 comments · Fixed by #15025
Closed

Display useful error message when embedding the whole app as iframe using Widgetize #14126

mattab opened this issue Feb 21, 2019 · 4 comments · Fixed by #15025
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@mattab
Copy link
Member

mattab commented Feb 21, 2019

When exporting in an iframe the whole application using the Widgetize feature, when users try to export a report's data, they click on "Export this dataset in other formats" which generates JS error "TypeError: dataTable is undefined".

Steps to reproduce

as reported by a customer:

  • for example using this URL:
    https://demo.matomo.org/index.php?module=Widgetize&action=iframe&moduleToWidgetize=CoreHome&actionToWidgetize=index&idSite=62&period=week&date=yesterday
  • go under a report and click export icon "Export this dataset in other formats"
  • Got: JS error "TypeError: dataTable is undefined" and the popover stays on "Loading Export..."
  • Expected to see the popover and choose export options, and successfully export the data.
@mattab mattab added the Bug For errors / faults / flaws / inconsistencies etc. label Feb 21, 2019
@mattab mattab added this to the 3.9.0 milestone Feb 21, 2019
@diosmosis diosmosis self-assigned this Feb 21, 2019
@diosmosis
Copy link
Member

@mattab I'm not sure if widgetizing the entire app is supported by Widgetize? should just need to create an iframe to module=CoreHome&action=index

@tsteur
Copy link
Member

tsteur commented Feb 21, 2019

This is not a supported feature and we're not really planning to add this @mattab

@tsteur
Copy link
Member

tsteur commented Feb 21, 2019

There are potentially heaps of issues and it can be potentially heaps of work to make it work etc. It be very very appreciated to close this issue as wont fix or keep it open as a feature enhancement for the future in the backlog.

@mattab
Copy link
Member Author

mattab commented Feb 21, 2019

Yes correct, we don't want to implement it 👍

That said, my suggestion would be: when module=Widgetize & moduleToWidgetize=CoreHome could we output a simple error message that says something like this (or better)

CoreHome embedding via an iframe is not a supported feature. Instead you can follow these steps:

  1. in your iframe, embed Matomo directly using module=CoreHome (instead of module=Widgetize) and
  2. change the INI setting as per this FAQ to allow iframing Matomo.

This would help guide users towards the supported way to do things (avoid bug reports) and make clear we don't support it.

@mattab mattab modified the milestones: 3.9.0, 3.11.0 Feb 21, 2019
@mattab mattab changed the title When Embedding the whole app as iframe, exporting reports doesn't work Display useful error message when embedding the whole app as iframe using Widgetize Feb 21, 2019
@katebutler katebutler assigned katebutler and unassigned diosmosis Oct 16, 2019
@mattab mattab modified the milestones: 3.13.0, 3.12.0 Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants