Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return http status 403 on failed login #14085

Closed
fdellwing opened this issue Feb 10, 2019 · 4 comments
Closed

Return http status 403 on failed login #14085

fdellwing opened this issue Feb 10, 2019 · 4 comments
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Milestone
Backlog (Help wan...

Comments

@fdellwing
Copy link
Contributor

Would it be possible to return a 403 http status code on the login post request if invalid credentials are used? This way the webserver and other software can capitalize on this information more easily.
@mattab
Copy link
Member

mattab commented Jun 18, 2019

Thanks for the suggestion 👍
Wondering if there could maybe be side effects on some server configuration, but probably not?

@mattab mattab added the Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. label Jun 18, 2019
@mattab
Copy link
Member

mattab commented Jun 18, 2019

Pull request welcome @fdellwing 👍

@mattab mattab added the Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. label Jun 18, 2019
@mattab mattab added this to the Backlog (Help wanted) milestone Jun 18, 2019
@fdellwing
Copy link
Contributor Author

I took a look into it and was not able to fiddle with the return codes. If anyone can hint me a method or example, will look into it further.

@pebosi pebosi mentioned this issue Jul 29, 2019
Merged
diosmosis pushed a commit that referenced this issue Aug 4, 2019
@pebosi @diosmosis
Send 403 header on failed Login (#14708)
7f61f6b 
* Send 403 header on failed Login

Proposal for #14085

* Update Controller.php

Use http_response_code
@Findus23
Copy link
Member

Findus23 commented Aug 4, 2019

Solved in #14708

@Findus23 Findus23 closed this as completed Aug 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Projects
None yet
Milestone
Backlog (Help wanted)
Development

No branches or pull requests
3 participants
@mattab @Findus23 @fdellwing