Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from bower to npm and update JS libraries #14082

Merged
merged 129 commits into from Jun 7, 2020
Merged

Switch from bower to npm and update JS libraries #14082

merged 129 commits into from Jun 7, 2020

Conversation

diosmosis
Copy link
Member

@diosmosis diosmosis commented Feb 9, 2019 •
edited

Still a WIP.

NOTE: This will require updates to premium plugins.

TODO (in other PRs most likely):

  • get tests to pass
  • update individual libraries and get tests to pass
  • BC for bower_components folder
  • run tests of premium plugins and get them to pass
  • replace other libraries in libs/ and in plugin directories

Refs #12961
Fixes #12067

@diosmosis diosmosis added Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Feb 9, 2019
@diosmosis diosmosis added this to the 3.9.0 milestone Feb 9, 2019
@Findus23 Findus23 mentioned this pull request Feb 10, 2019
Merged
@diosmosis
Copy link
Member Author

@sgiehl the fix for the tooltip issue is to switch to materialize, which I haven't looked into yet. The archiving PRs are currently my focus.

@sgiehl
Copy link
Member

sgiehl commented Jun 5, 2020

@diosmosis I've tried switching to materialize tooltips. But it's a bit more work to do as I thought. We are using callbacks in some cases to determine the content of the tooltips and whether they should be shown or not. That is not supported by materialize tooltips. So we would need to change that. Also materialize uses the same jQuery wrapper for tooltips as jquery ui, so we can't use the .tooltip() method anymore or would need to use a custom jquery ui build without the tooltips...

I've now pushed a hackish solution that only fixes the issue for the datatable row actions. Might be enough for the moment, as I didn't find any other overlapping tooltip yet. Maybe we can go with this solution for now and create a follow up issue to maybe even remove jquery ui completely with a later release.

@diosmosis
Copy link
Member Author

I've now pushed a hackish solution that only fixes the issue for the datatable row actions.

If it works, this sounds good to me, whatever takes the least amount of time at this point.

diosmosis added a commit to matomo-org/plugin-AnonymousPiwikUsageMeasurement that referenced this pull request Jun 7, 2020
@diosmosis
Merge pull request #55 from matomo-org/12961-screenshots
ebda218 
Screenshot changes for matomo-org/matomo#14082
diosmosis added a commit to matomo-org/plugin-Bandwidth that referenced this pull request Jun 7, 2020
@diosmosis
Merge pull request #28 from matomo-org/12961-screenshots
9ca3adb 
screenshot changes for matomo-org/matomo#14082
diosmosis added a commit to matomo-org/plugin-CustomAlerts that referenced this pull request Jun 7, 2020
@diosmosis
Merge pull request #78 from matomo-org/12961-screenshots
8343157 
screenshot changes for matomo-org/matomo#14082
diosmosis added a commit to matomo-org/plugin-CustomDimensions that referenced this pull request Jun 7, 2020
@diosmosis
Merge pull request #157 from matomo-org/12961-screenshots
d36a3d5 
screenshot changes for matomo-org/matomo#14082
diosmosis added a commit to matomo-org/plugin-LogViewer that referenced this pull request Jun 7, 2020
@diosmosis
Merge pull request #23 from matomo-org/12961-screenshots
4e2f78a 
screenshot changes for matomo-org/matomo#14082
diosmosis added a commit to matomo-org/plugin-MarketingCampaignsReporting that referenced this pull request Jun 7, 2020
@diosmosis
Merge pull request #43 from matomo-org/12961-screenshots
0bbac4e 
screenshot changes for matomo-org/matomo#14082
diosmosis added a commit to matomo-org/plugin-QueuedTracking that referenced this pull request Jun 7, 2020
@diosmosis
Merge pull request #135 from matomo-org/12961-screenshots
80aa290 
screenshot changes for matomo-org/matomo#14082
diosmosis added a commit to matomo-org/plugin-SecurityInfo that referenced this pull request Jun 7, 2020
@diosmosis
Merge pull request #45 from matomo-org/12961-screenshots
87face9 
screenshot changes for matomo-org/matomo#14082
diosmosis added a commit to matomo-org/plugin-TasksTimetable that referenced this pull request Jun 7, 2020
@diosmosis
Merge pull request #19 from matomo-org/12961-screenshots
511c485 
screenshot changes for matomo-org/matomo#14082
diosmosis added a commit to matomo-org/plugin-TreemapVisualization that referenced this pull request Jun 7, 2020
@diosmosis
Merge pull request #22 from matomo-org/12961-screenshots
02792a0 
screenshot changes for matomo-org/matomo#14082
@diosmosis diosmosis merged commit d0aaab9 into 4.x-dev Jun 7, 2020
@diosmosis diosmosis deleted the 12961-npm-and-updates branch June 7, 2020 23:47
This was referenced Jun 7, 2020
Closed
Closed
Closed
This was referenced Jun 9, 2020
Merged
Merged
@sgiehl sgiehl mentioned this pull request Jun 17, 2020
Merged
@diosmosis diosmosis mentioned this pull request Jul 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl requested changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

Replace Bower (and libs/) with npm
5 participants
@diosmosis @Findus23 @tsteur @sgiehl @mattab