Search for visitor IDs over whole table not just last 30 mins #14069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should work and in theory not introduce a performance regression 👍 |
…g_visit table instead of just in the last 30 mins.
sgiehl
force-pushed
the
recognize-visitor-no-limit
branch
from
d9dab66
to
eb934c0
Compare
|
FYI, I've been fixing tests for this in #13935 which contains this change + some fixes, this PR probably shouldn't be merged. I think it's good to have it open for any discussion though. I'll close it when I merge the other one. |
diosmosis
added
Pull Request WIP
|
Included in #13935 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the tracker when searching by visitor ID, search through entire log_visit table instead of just in the last 30 mins.
Should be fast thanks to already existing index (h/t @tsteur)
CC @mattab can you take a look at this re any possible privacy implications?