@diosmosis opened this Pull Request on February 4th 2019 Member

In the tracker when searching by visitor ID, search through entire log_visit table instead of just in the last 30 mins.

Should be fast thanks to already existing index (h/t @tsteur)

CC @mattab can you take a look at this re any possible privacy implications?

@mattab commented on February 21st 2019 Member

Should work and in theory not introduce a performance regression :+1:

@sgiehl commented on February 25th 2019 Member

Should work and in theory not introduce a performance regression

@tsteur @mattab should we maybe test that on some bigger cloud instances before merging? Otherwise tests may need some updates, but would be good to merge then.

@diosmosis commented on February 25th 2019 Member

FYI, I've been fixing tests for this in https://github.com/matomo-org/matomo/pull/13935 which contains this change + some fixes, this PR probably shouldn't be merged. I think it's good to have it open for any discussion though. I'll close it when I merge the other one.

@diosmosis commented on March 14th 2019 Member

Included in #13935

This Pull Request was closed on March 14th 2019
Powered by GitHub Issue Mirror