@diosmosis opened this Pull Request on February 1st 2019 Member

This will have to change when the visitor timeline is put in.

Fixes #13136
Fixes #12894

@diosmosis commented on February 23rd 2019 Member

Merged w/ 3.x-dev, and here's what it looks like w/ a small visit:

image

and a large visit:

mamp_8888_index php_module corehome action index idsite 1 period day date 2019-02-06 updated 3

and for content actions:

image

image

@sgiehl commented on February 25th 2019 Member

@diosmosis I've merged in the latest 3.x-dev changes. But it seems it's currently broken. Always seeing the error No entry or class found for 'Live.pageViewActionsToDisplayCollapsed'. Guess that's caused here: https://github.com/matomo-org/matomo/pull/14063/files#diff-541de4bc6a9bb0d9cad5f733b4b853eeR122
Did you maybe forget to commit/add something?

@diosmosis commented on February 25th 2019 Member

@sgiehl added the missing file.

@sgiehl commented on March 11th 2019 Member

@diosmosis Seems the visitor profile is broken now. Getting this error when opening one:

Variable "actionGroups" does not exist.
in ./plugins/Live/templates/_actionsList.twig line 2            
@diosmosis commented on March 12th 2019 Member

@sgiehl updated to work in visitor profile. not sure if the implementation is the best or not, let me know if you see room for improvement.

@tsteur commented on March 12th 2019 Member

image
not sure if colours were adjusted in this or another PR but seeing there are icons from premium features in different colour. Is it better to fix this in core or in the premium features?

@diosmosis commented on March 12th 2019 Member

@tsteur The css class used is determined by the plugin due to how the template is defined, so better in the plugin i'd say.

@tsteur commented on March 12th 2019 Member

when I click on "show more actions" it doesn't show more actions.

image

Also I have a visit where it sometimes shows the "show more link" after 7 actions within a pageview, and sometimes only after 20 shows the "show more link":
image

In general it looks a bit "bloated" I wonder if some additional spacing might help? We could maybe also ask our designers to tweak it maybe.

image

Also I see action images were changed to SVG? that's a problem cause it breaks the mobile app and possibly other consumers. They are supposed to return actual images. Maybe in Matomo we can use SVG but the API should still return proper images. I suppose this was maybe changed in another PR.

@tsteur commented on March 12th 2019 Member

@tsteur The css class used is determined by the plugin due to how the template is defined, so better in the plugin i'd say.

@diosmosis OK I will check to see how to maybe detect the Matomo version and then change the colour of the icon depending on the version cause for older installations we still want to show the black color

@tsteur commented on March 12th 2019 Member

also just seeing for some reason it doesn't show form interactions within the page view. Is that possible?

image

@diosmosis commented on March 12th 2019 Member

@tsteur

when I click on "show more actions" it doesn't show more actions.

I assume you did a hard reload? I've seen this issue, but should have been working... same for the show more link for 7 actions. Then again, maybe the selector is using the core .action... will look.

also just seeing for some reason it doesn't show form interactions within the page view. Is that possible?

If there's no pageview ID set for the action (or the wrong pageview ID is set), then it won't be grouped. Are you looking at the demo data? pageview IDs aren't always set correctly there.

@tsteur commented on March 12th 2019 Member

Another minor issue probably also from the other PR. The goal icon is not quite aligned on the left with the icons from the timeline

image

@tsteur commented on March 12th 2019 Member

@diosmosis could we add color: <a href='/999'>#999</a> to .action-list-action-icon {} then it would just render the color of the icons fine for all premium features as well and wouldn't need to define it individually in each premium feature.

@tsteur commented on March 12th 2019 Member

I assume you did a hard reload? I've seen this issue, but should have been working... same for the show more link for 7 actions. Then again, maybe the selector is using the core .action... will look.

I've done a hard reset but doesn't work. They don'T have the .action AFAIK but the action-list-action-icon.

If there's no pageview ID set for the action (or the wrong pageview ID is set), then it won't be grouped. Are you looking at the demo data? pageview IDs aren't always set correctly there.

I checked and it was fetching the idpageview but not returning it. I will release a new version of form analytics 👍

Overall love how much better it is with the grouping 👍 💯

@diosmosis commented on March 12th 2019 Member

@tsteur Also I see action images were changed to SVG? that's a problem cause it breaks the mobile app and possibly other consumers. They are supposed to return actual images. Maybe in Matomo we can use SVG but the API should still return proper images. I suppose this was maybe changed in another PR.

This was done in a previous PR, the action images were turned into SVG, but we're still using <img /> links (though might be better to eventually embed svgs).

@tsteur commented on March 12th 2019 Member

Code looks otherwise straight forward 👍

@tsteur commented on March 12th 2019 Member

This was done in a previous PR, the action images were turned into SVG, but we're still using links (though might be better to eventually embed svgs).

Should I create an issue to undo this? The API would really need to return proper images to not be breaking. Not every system can render SVG

@diosmosis commented on March 12th 2019 Member

@tsteur Made a couple fixes. Re it looking bloated, does this look better?

image

Upped the margin-bottom from 7px to 10px. Not sure if it really makes a difference, going up to 14px looked more or less the same to me.

Should I create an issue to undo this? The API would really need to return proper images to not be breaking. Not every system can render SVG

Probably, not sure if the old images are still in the repo? Would want to cc @sgiehl , maybe we can add an iconSvg property to the API response.

@tsteur commented on March 13th 2019 Member

IconSVG could work in the API response 👍

Can we maybe remove the last vertical line under an icon for the last action within a pageview?

image

and for some reason sometimes it looks like there's not enough space between the last action of a pageview, and the next page view
image

while it seems better for some others

image

I wonder if we should even remove the vertical line under an icon when the action is on one line only as it is rather irritating maybe. Or maybe we could have a longer minheight for it?

image

I reckon those changes could make a good difference.

The "show more/less" works now 👍

@diosmosis commented on March 13th 2019 Member

@tsteur Made some tweaks, can you check whether it looks better to you?

@tsteur commented on March 13th 2019 Member

Yes looks good 👍

@diosmosis commented on March 13th 2019 Member
@diosmosis commented on March 14th 2019 Member

@tsteur / @mattab updated to show refreshes and allow expanding, maybe you guys want to take a look before merging?

@tsteur commented on April 11th 2019 Member

I suppose we could merge it now and make further changes if needed after using it for a while @mattab @diosmosis ?

@mattab commented on April 11th 2019 Member

I suppose we could merge it now and make further changes if needed after using it for a while

:+1:

This Pull Request was closed on May 14th 2019
Powered by GitHub Issue Mirror