New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
One Click Install UI test #14049
One Click Install UI test #14049
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some minor comments. Otherwise test seems to work 👍
Applied PR feedback. Edit: note: this is still waiting on the matomo-package PR. |
@diosmosis did you remove the |
Yes, thought I removed the spec file too, must have forgot. Will do so. EDIT: Actually, you're right, deleted too many files... put those back. |
06a4329
to
c5e6b5d
Compare
c5e6b5d
to
d0c8f2c
Compare
Looks good as well 👍 Didn't look in detail but as long as the tests work should be all fine. |
This PR can be reviewed but should not be merged until matomo-org/matomo-package#93 is merged (and the git clone is changed in this PR).
Changes:
h/t to @Findus23 for original idea
Todo: