@diosmosis opened this Pull Request on January 29th 2019 Member

This PR can be reviewed but should not be merged until https://github.com/matomo-org/matomo-package/pull/93 is merged (and the git clone is changed in this PR).

Changes:

  • Added new fixture LatestStableInstall that installs the latest stable version and packages the git checkout.
  • Added a UI test for OneClickInstall.

h/t to @Findus23 for original idea

Todo:

  • [ ] ensure core:archive command works after update
@diosmosis commented on February 25th 2019 Member

Applied PR feedback.

Edit: note: this is still waiting on the matomo-package PR.

@sgiehl commented on February 27th 2019 Member

@diosmosis did you remove the CoreUpdateDb ui files on purpose? The spec file is still there and so the tests are failing

@diosmosis commented on February 27th 2019 Member

Yes, thought I removed the spec file too, must have forgot. Will do so.

EDIT: Actually, you're right, deleted too many files... put those back.

@tsteur commented on April 11th 2019 Member

Looks good as well 👍 Didn't look in detail but as long as the tests work should be all fine.

This Pull Request was closed on May 16th 2019
Powered by GitHub Issue Mirror