Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One Click Install UI test #14049

Merged
merged 34 commits into from May 16, 2019
Merged

One Click Install UI test #14049

merged 34 commits into from May 16, 2019

Conversation

diosmosis
Copy link
Member

@diosmosis diosmosis commented Jan 29, 2019

This PR can be reviewed but should not be merged until matomo-org/matomo-package#93 is merged (and the git clone is changed in this PR).

Changes:

  • Added new fixture LatestStableInstall that installs the latest stable version and packages the git checkout.
  • Added a UI test for OneClickInstall.

h/t to @Findus23 for original idea

Todo:

  • ensure core:archive command works after update

@diosmosis diosmosis added c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Jan 29, 2019
@diosmosis diosmosis added this to the 3.9.0 milestone Jan 29, 2019
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor comments. Otherwise test seems to work 👍

plugins/CoreUpdater/Controller.php Outdated Show resolved Hide resolved
tests/UI/specs/OneClickUpdate_spec.js Outdated Show resolved Hide resolved
@diosmosis
Copy link
Member Author

diosmosis commented Feb 25, 2019

Applied PR feedback.

Edit: note: this is still waiting on the matomo-package PR.

@sgiehl
Copy link
Member

sgiehl commented Feb 27, 2019

@diosmosis did you remove the CoreUpdateDb ui files on purpose? The spec file is still there and so the tests are failing

@diosmosis
Copy link
Member Author

diosmosis commented Feb 27, 2019

Yes, thought I removed the spec file too, must have forgot. Will do so.

EDIT: Actually, you're right, deleted too many files... put those back.

@mattab mattab modified the milestones: 3.9.0, 3.10.0 Mar 18, 2019
@tsteur
Copy link
Member

tsteur commented Apr 11, 2019

Looks good as well 👍 Didn't look in detail but as long as the tests work should be all fine.

@diosmosis diosmosis merged commit 03ca651 into 3.x-dev May 16, 2019
@diosmosis diosmosis deleted the one-click-install-ui-test branch May 16, 2019 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants