@tsteur opened this Pull Request on January 28th 2019 Member

Eg when Matomo is not installed, it would still dispatch the request in https://github.com/matomo-org/matomo/blob/3.8.1-b1/plugins/Installation/Installation.php#L111 even when PIWIK_ENABLE_DISPATCH is disabled.

Will set it to WIP for now as I'm not sure if we want to have this actually merged or not.

@tsteur commented on January 30th 2019 Member

Not sure we can easily add a test for this? Basically the idea is to throw the exception when dispatch is disabled.

@tsteur commented on March 11th 2019 Member

Not sure it's so easily possible to test as we need to bootstrap Matomo and set PIWIK_ENABLE_DISPATCH to false. Could maybe embed a PHP file in the test directory that bootstraps it. It should actually throw an exception in this case. Might quickly have a look later.

@tsteur commented on March 11th 2019 Member

added a test @sgiehl

This Pull Request was closed on March 13th 2019
Powered by GitHub Issue Mirror