Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect password issue #14027

Closed
daganM opened this issue Jan 27, 2019 · 5 comments · Fixed by #14033
Closed

Incorrect password issue #14027

daganM opened this issue Jan 27, 2019 · 5 comments · Fixed by #14033
Labels
Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Milestone
3.8.1

Comments

@daganM
Copy link

daganM commented Jan 27, 2019

No idea why,
I can connect to Matomo (on my server) with my password, but when I want to change password or enable 2FA, it tells me I've entered an incorrect password.

Already updated my password once, it worked. Only change : updated from 3.7 to 3.8 today.
@tsteur
Copy link
Member

tsteur commented Jan 27, 2019

Are you using any specific login plugin?

@daganM
Copy link
Author

daganM commented Jan 27, 2019

Absolutely not !

@tsteur
Copy link
Member

tsteur commented Jan 27, 2019

Are there any special characters in there? I can imagine it might have problems with them

@tsteur tsteur added the Regression Indicates a feature used to work in a certain way but it no longer does even though it should. label Jan 27, 2019
@tsteur tsteur added this to the 3.8.1 milestone Jan 27, 2019
tsteur added a commit that referenced this issue Jan 28, 2019
@tsteur
Make sure to compare password with unsanitized password
b484810 
fix #14027
@tsteur tsteur mentioned this issue Jan 28, 2019
Merged
@tsteur
Copy link
Member

tsteur commented Jan 28, 2019

To reproduce this issue I executed php -r 'echo password_hash(md5("23#<>test"), PASSWORD_DEFAULT) . "\n";' and updated my password with eg $2y$10$C/Can/L9h4tar3tWXbUjWeN0gW3zysKOyctgcwX.ZT8LIm7YFSOqS.
Also tested it by creating a new user with password 23#<>test. Can reproduce the issue and created PR

@daganM
Copy link
Author

daganM commented Jan 30, 2019

I can confirm I do not have the issue anymore with 3.8.1 ! Thank you for your quick fix !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
3.8.1
Development

Successfully merging a pull request may close this issue.

Make sure to compare password with unsanitized password matomo-org/matomo
2 participants
@tsteur @daganM