Allow throwing exceptions for HTTP error codes to better check query param input. #14023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diosmosis
added
the
not-in-changelog
sgiehl
requested changes
Jan 28, 2019
|
@diosmosis this one needs a rebase / merge to solve the conflicts |
tsteur
reviewed
Apr 11, 2019
tsteur
reviewed
Apr 11, 2019
|
Left 2 comments, otherwise good to merge when tests pass 👍 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added two new exceptions
HttpCodeExceptionandBadRequestExceptionthat allows changing the HTTP code returned for an exception (in both controller & API).This allows us to avoid certain failures caused by invalid input and correctly report the error, w/o triggering a 500 HTTP code (that could potentially also create an email alert?).
Used in ScheduledReports API to check for multiple periods.
Fixes #13752