@fdellwing opened this Issue on January 23rd 2019 Contributor

There are two problems with the iframe builder right now.

1. If you choose em instead of px and enter a float number, this number is not getting added to the iframe code. It only accepts integers.

  1. If you choose white as font color the background color is still transparent (so the iframe seems empty), but the builder shows black in the color picker.
@Findus23 commented on January 23rd 2019 Member

For the latter, I can't think of any other solution as to set the color to white by default which feels a bit redundant and makes transparent impossible to select. Maybe an additional "transparent" button has to be added.

@tsteur commented on January 23rd 2019 Member

We don't support white etc right? may be best to just not support it before making things overly complex

@fdellwing commented on January 24th 2019 Contributor

@tsteur I'm not sure what you mean with "We don't support white etc"? You have a color picker there, you can choose any color you want and that includes off course white, too.

Edit: Just to be sure, I do not talk about the word white. I talk about choosing #FFFFFF in the color picker.

@fdellwing commented on January 24th 2019 Contributor

It seems like 1. works, but in another way than I thought. If I enter 1,5 it works as expected.

For 2. a PR will follow soon :)

@tsteur commented on January 24th 2019 Member

We originally only wanted to support hex values, I think then RGB was added but weren't supporting any colours directly but maybe this was added. I think my color picker in my browser doesn't return white but if others do I guess we should support it.

@fdellwing commented on January 24th 2019 Contributor

I'm still not sure, you are understanding the problem here ;)

@tsteur commented on January 24th 2019 Member

I do I do... it was about the white/transparent background with white text :)

Powered by GitHub Issue Mirror