Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opt-out iframe builder broken #14008

Closed
fdellwing opened this issue Jan 23, 2019 · 7 comments
Closed

Opt-out iframe builder broken #14008

fdellwing opened this issue Jan 23, 2019 · 7 comments
Labels
answered For when a question was asked and we referred to forum or answered it.

Comments

@fdellwing
Copy link
Contributor

fdellwing commented Jan 23, 2019

There are two problems with the iframe builder right now.

1. If you choose em instead of px and enter a float number, this number is not getting added to the iframe code. It only accepts integers.

  1. If you choose white as font color the background color is still transparent (so the iframe seems empty), but the builder shows black in the color picker.
@Findus23
Copy link
Member

For the latter, I can't think of any other solution as to set the color to white by default which feels a bit redundant and makes transparent impossible to select. Maybe an additional "transparent" button has to be added.

@tsteur
Copy link
Member

tsteur commented Jan 23, 2019

We don't support white etc right? may be best to just not support it before making things overly complex

@fdellwing
Copy link
Contributor Author

fdellwing commented Jan 24, 2019

@tsteur I'm not sure what you mean with "We don't support white etc"? You have a color picker there, you can choose any color you want and that includes off course white, too.

Edit: Just to be sure, I do not talk about the word white. I talk about choosing #FFFFFF in the color picker.

@fdellwing
Copy link
Contributor Author

It seems like 1. works, but in another way than I thought. If I enter 1,5 it works as expected.

For 2. a PR will follow soon :)

@tsteur
Copy link
Member

tsteur commented Jan 24, 2019

We originally only wanted to support hex values, I think then RGB was added but weren't supporting any colours directly but maybe this was added. I think my color picker in my browser doesn't return white but if others do I guess we should support it.

@fdellwing
Copy link
Contributor Author

I'm still not sure, you are understanding the problem here ;)

@tsteur
Copy link
Member

tsteur commented Jan 24, 2019

I do I do... it was about the white/transparent background with white text :)

@mattab mattab added the answered For when a question was asked and we referred to forum or answered it. label Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
answered For when a question was asked and we referred to forum or answered it.
Projects
None yet
Development

No branches or pull requests

4 participants