@diosmosis opened this Pull Request on January 23rd 2019 Member

The sparkline lib we use converts all values to integers (see the FormatTrait.php file) which means float
numbers that are close to 1.0 or 0.0 will get floored to 1/0. This can happen in the average page generation time report, and cause some values which are, eg, around ~.9 to appear as 0 in the sparkline. To workaround this I made a change to scale the values if a float is found.

@tsteur commented on January 28th 2019 Member

Looks good if tests pass

@diosmosis commented on January 28th 2019 Member

Test failing, moving to 3.9

@Findus23 commented on March 11th 2019 Member

It definitely wasn't intentional by me and I think it looks better now (especially percentages)

@Findus23 commented on July 3rd 2019 Member

Interestingly someone reported a similar sounding issue in 3.10:
@diosmosis Do you have any idea why it could occur?

@diosmosis commented on July 3rd 2019 Member

@Findus23 from looking at the code I would guess the values have characters that aren't numeric. There's some code there that removes percents and other unit values, maybe it's not working here. I wonder if using &format_metrics=0 in the sparkline visualization would prevent that...

This Pull Request was closed on March 12th 2019
Powered by GitHub Issue Mirror