@diosmosis opened this Pull Request on January 23rd 2019 Member

Also truncates url to 120 chars.

The tooltip delay is reduced to 100ms. I couldn't reproduce the stuck tooltip issue yhat the delay fixed, so hoping it will be ok.

Fixes #13991

@mzcarlos commented on January 23rd 2019

Also truncates url to 120 chars.

The tooltip delay is reduced to 100ms. I couldn't reproduce the stuck tooltip issue the delay fixed, so hoping it will be ok.

Fixes #13991

I tried your commit but it didn't fix the delay. It must be anything else.

However, I noticed something that might help you to find the issue. In the live widget, the country, browser, operating system and device type tooltips still appear immediately. The visitor profile and the viewed pages do not.

Thank you!

@diosmosis commented on January 23rd 2019 Member

@mzcarlos can you try again after clearing your browser cache and running the ./console cache:clear command?

@mzcarlos commented on January 23rd 2019

@diosmosis the ./console cache:clear command fixed it! I was clearing the browser cache but didn't know about the server cache. Now it works fine. The title in its own line looks nice too. Thank you very much.

@tsteur commented on January 27th 2019 Member

Left a comment, otherwise looks good

@diosmosis commented on January 28th 2019 Member

Added if to detect empty actions.

@fdellwing commented on January 28th 2019 Contributor

Why did the truncation get removed again in the progress of this PR?

@diosmosis commented on January 28th 2019 Member
@dev-101 commented on January 28th 2019

Any chance we can customize the tooltip?
I mean, I don't (no, really don't) need URL address in the tooltip. It just makes things cramped. KISS rules.

edit: If I want URL details I'll open the log.

@tsteur commented on January 28th 2019 Member

@dev-101 @fdellwing every one uses it differently and we can't make it right for everyone. The only solution be probably to write a plugin that removes this part through JS or maybe PHP. May not be that easy.

@dev-101 commented on January 28th 2019

That's why I'm asking ;)

I don't see any filter hooks in there, and no classes to customize it through CSS. Just some hackish solution if possible at all. I would also remove timestamps, again, if I need them > full log is available.

@diosmosis commented on January 28th 2019 Member

I can add CSS classes to each line in the tooltip.

@dev-101 commented on January 29th 2019

Please do :)
Thanks!

This Pull Request was closed on January 28th 2019
Powered by GitHub Issue Mirror