@diosmosis opened this Pull Request on January 23rd 2019 Member

This is specifically for ProxySite where reports will request a filter_limit/offset, and the target instance will apply it once, and we don't want to apply it a second time in the proxy instance.

The alternative is to always send filter_limit=-1 and apply the limit in the proxy instance, but that would mean a lot of data transfer. Especially for Live APIs, which just time out for me (of course they would).

@tsteur commented on January 25th 2019 Member

Haven't tested it but looks fine. A test may be good if easy to do.

Just to understand correctly on the instance that has proxySite we will basically disable the limit filter as this would have been applied again otherwise?

@diosmosis commented on January 25th 2019 Member

Just to understand correctly on the instance that has proxySite we will basically disable the limit filter as this would have been applied again otherwise?

Yes, correct.

@diosmosis commented on January 27th 2019 Member

Added unit test.

This Pull Request was closed on January 27th 2019
Powered by GitHub Issue Mirror