Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset tracked impressions for searches and only send tracking request when interaction was defined #14002

Merged
merged 3 commits into from Apr 8, 2019
Merged

Reset tracked impressions for searches and only send tracking request when interaction was defined #14002

merged 3 commits into from Apr 8, 2019

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Jan 23, 2019

fix #13988

In #13988 noticed couple problems:

  • The content impressions are not reset when calling trackSiteSearch, only when calling trackPageview
  • The method buildContentInteractionRequestNode may return null|undefined in which case we should not send the request. Not sure what Matomo would do but it would possibly track a pageview instead of an interaction

@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Jan 23, 2019
@tsteur tsteur added this to the 3.9.0 milestone Jan 23, 2019
@tsteur tsteur mentioned this pull request Jan 23, 2019
Closed
@theseyi
Copy link

theseyi commented Jan 23, 2019

Awesome! Thanks @tsteur 👍

@theseyi
Copy link

theseyi commented Feb 7, 2019

@tsteur not to bug, a couple questions

  • Is there a ETA or timeline for this getting merged and publicly released?
  • in the interim, would it suffice for me to manually pull in the updated js files in my app to take advantage of this fix?

thanks

@tsteur
Copy link
Member Author

tsteur commented Feb 7, 2019

Is there a ETA or timeline for this getting merged and publicly released?

I reckon within the next 6 weeks

in the interim, would it suffice for me to manually pull in the updated js files in my app to take advantage of this fix?

Yes, you can simple update the piwik.js: https://raw.githubusercontent.com/matomo-org/matomo/fe2eebbca7c2f05e6ff95ff389d5878a3bb7ba5c/piwik.js and matomo.js: https://raw.githubusercontent.com/matomo-org/matomo/fe2eebbca7c2f05e6ff95ff389d5878a3bb7ba5c/matomo.js
(both same content)

@mattab mattab modified the milestones: 3.9.0, 3.10.0 Mar 18, 2019
@diosmosis
Copy link
Member

@tsteur is there a test that can be added for this?

@tsteur
Copy link
Member Author

tsteur commented Apr 7, 2019

@diosmosis added a test for the trackSiteSearch reset, and merged 3.x-dev in so the PR can be merged.

@diosmosis diosmosis merged commit ff1c579 into 3.x-dev Apr 8, 2019
@diosmosis diosmosis deleted the contentinteractionrequest branch April 8, 2019 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.10.0
Development

Successfully merging this pull request may close these issues.

Content Tracking: Interactions count greater than impressions count
4 participants
@tsteur @theseyi @diosmosis @mattab