@tsteur opened this Pull Request on January 23rd 2019 Member

fix #13988

In #13988 noticed couple problems:

  • The content impressions are not reset when calling trackSiteSearch, only when calling trackPageview
  • The method buildContentInteractionRequestNode may return null|undefined in which case we should not send the request. Not sure what Matomo would do but it would possibly track a pageview instead of an interaction
@theseyi commented on January 23rd 2019

Awesome! Thanks @tsteur :+1:

@theseyi commented on February 7th 2019

@tsteur not to bug, a couple questions

  • Is there a ETA or timeline for this getting merged and publicly released?
  • in the interim, would it suffice for me to manually pull in the updated js files in my app to take advantage of this fix?

thanks

@tsteur commented on February 7th 2019 Member

Is there a ETA or timeline for this getting merged and publicly released?

I reckon within the next 6 weeks

in the interim, would it suffice for me to manually pull in the updated js files in my app to take advantage of this fix?

Yes, you can simple update the piwik.js: https://raw.githubusercontent.com/matomo-org/matomo/fe2eebbca7c2f05e6ff95ff389d5878a3bb7ba5c/piwik.js and matomo.js: https://raw.githubusercontent.com/matomo-org/matomo/fe2eebbca7c2f05e6ff95ff389d5878a3bb7ba5c/matomo.js
(both same content)

Powered by GitHub Issue Mirror