Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore .lfsconfig in file integrity system check #13997

Merged
merged 1 commit into from Jan 23, 2019
Merged

Ignore .lfsconfig in file integrity system check #13997

merged 1 commit into from Jan 23, 2019

Conversation

mattab
Copy link
Member

@mattab mattab commented Jan 22, 2019

fixes #13995

@mattab mattab added this to the 3.8.1 milestone Jan 22, 2019
@mattab mattab added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Jan 22, 2019
@Findus23
Copy link
Member

That's of course a solution I didn't think of. 🙂

But I am not sure if this is the full solution as it would mean we need to make an exception for every file that will get deleted by a Matomo release (e.g. this time there is also misc/internal-docs/content-tracking.md)

@diosmosis
Copy link
Member

Tried to add a test for this, but couldn't find a way to generate the manifest file. Perhaps if the logic were moved into a matomo command or something it would be possible. For now will just merge.

@diosmosis diosmosis merged commit df561f7 into 3.x-dev Jan 23, 2019
@diosmosis diosmosis deleted the 13995 branch January 23, 2019 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explain better why sometimes files "appear" after updates
4 participants