Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Matomo 3.8.0 #13996

Merged
merged 350 commits into from Jan 22, 2019
Merged

Release Matomo 3.8.0 #13996

merged 350 commits into from Jan 22, 2019

Conversation

mattab
Copy link
Member

@mattab mattab commented Jan 22, 2019

No description provided.

diosmosis and others added 30 commits October 11, 2018 16:44
* Update expected screenshots.

* Update screenshot.
* don't post travis results to IRC

* Remove slack notifications.
* Add tests for password resetter and tweak process a bit.

* Add random string to reset key suffix.

* Tweak email message.

* Fixing tests (includes change to always use latest testing environment variables during tests).

* Tweak to randomstring
…pecify a value for date" (#13651)

Seems to be pretty much the only usage of strDate (checked if it is used in other places too).
Not tested but fix this fatal error
> Error: {"message":"Call to a member function getColumn() on boolean","file":"plugins\/Live\/VisitorProfile.php","line":86}

Happened eg on 
> module=API&method=Live.getVisitorProfile&idSite=1&format=JSON&token_auth=XYZANONYMIZED&visitorId=b06bc6d6274c1244&limitVisits=-1
* Regenerate htaccess files after update

just in case someone deleted them manually or by accident

* acquire lock in case multiple updaters are running at the same time in one filesystem
* fix switch return in CreatePull

* use continue 2 instead
* Added API endpoint to return the php version info

* Do not test API.getPhpVersion

* Updated expected screenshot

* User must have super user access to access the php version
…#13660)

* Show the CORS settings in the UI when enable_general_settings_admin=0

The INI setting description does not mean to include CORS:
```ini

; By setting this option to 0, the following settings will be hidden and disabled from being set in the UI:
; - "Archiving Settings"
; - "Update settings"
; - "Email server settings"
enable_general_settings_admin = 1
```

* improve the meaning of enable_general_settings_admin = 1

* Do not allow to configure trusted hostnames if general settings are disabled
…ed. (#13554)

* Update session cookie on each request if session was remembered.

* Fix unit test.
* fix domain age from archive.org

* fix test

* improve archive.org error handling
fix #12266

fyi @mattab couldn't make it work to show `0` instead of `-`. 
Now all the reports have the same length by default on the devices page. If someone wants to see more, they can increase the limit. Or if many are `-` then they can choose only `5` in the limit selection and it will apply this setting next time.
diosmosis and others added 27 commits January 15, 2019 17:10
* Don't cache tag manager preview files

Not sure if this will work across apache versions? Tested on Apache 2.2

Prevents preview files from being cached in the browser and that always the newest version will be served.

refs matomo-org/tag-manager#150

* Update ServerFilesGenerator.php
* Append token_auth to sparkline urls for embedded widgets

* append token_auth to sparklines only in Widgetize mode
* Open site in new tab/window if ctrl key is pressed

* check for meta key on OS X
* Add segmented visitorlog feature to page title reports

* Add segmented visitorlog feature to site search keywords reports

* Adds new AddSegmentByRangeLabel filter

* updates tests

* improve check for summary row

* Handle new visits row segment
* Updating expected test files.

* Update submodule.

* Fix unit test.

* Update expected screenshots.

* Update more expected files.
#13909)

* Add UI test for complex segment + fix couple bugs to get test to pass.

* fix test
* add all goal  metrics to goals overview graph

* add conversion rates

* correctly calculate conversion rate

* more fixes

* performance tweak

* improve performance of getMetric when having heaps of goals

* fix conversion rate might not be shown properly

* add parameter to fetch all goal metrics
* improve RSS fetching

* add cache to rss fetching and remove "appeared first on" appendix

* remove special handling of RSS description

* Make sure links in rss content open in new tab and have noreferrer noopener.
refs #13883 and #13892

Checking for `$cache->contains($lazyCacheId)` and then `$cache->fetch($lazyCacheId)` can run into race conditions when the cache expires just in between. I reckon this might be the case for #13892 which we see happening like once a day or every other day.

We would possibly also need to check for other usages. Might not actually be an issue cause the transient is used in the lazy cache as well and it should keep the entry during the same request. It could come to this issue though the first time a cache entry is read.
* Increase the time before an archive is considered outdated

Browser archiving is already slow enough so we shouldn't do it every 2.5minutes IMO. Personally, I would even set it to 30 or 60 minutes, not 15 minutes like in this PR.
This improves the performance at least a little when users don't set up cli archiving.
@mattab

* fix couple tests
…the same visit (#13727)

* It is not possible to record more than one conversion per second for the same visit

fix #9916

we randomize the first 2 numbers increasing the chances to record multiple goal conversions per second per visit.

* make sure to generate mysql safe int

* Update GoalManager.php
Note that this does not handle cases where users delete the whole tmp/
directory. However, it is to be expected that users depending on
that file would take care not to delete it.

Fixes #12754
@mattab mattab added this to the 3.8.0 milestone Jan 22, 2019
@mattab mattab merged commit 7ae317c into master Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet