Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify supported PHP versions #13985

Closed
J0WI opened this issue Jan 22, 2019 · 4 comments
Closed

Clarify supported PHP versions #13985

J0WI opened this issue Jan 22, 2019 · 4 comments
Labels
answered For when a question was asked and we referred to forum or answered it.

Comments

@J0WI
Copy link

J0WI commented Jan 22, 2019

The current system requirements are "PHP version >= 5.5.9".
This is not true. PHP 7.2 throws warnings before Matomo 3.8.0 and PHP 7.3 still does.
No warnings should be present in officially supported PHP versions.

See also:
#11936: tests are only run on PHP 5
#13272: fixes issue with PHP 7.2
#13418: PHP 7.3 issues

@Findus23
Copy link
Member

Hi, I agree that there are still issues with 7.3 (but this should only be warnings by PHP that the coding style is ambiguous and nothing that changes how PHP works).
This mostly depends on #13639 which has the potential to break things for 5.x users as the latest version of the library doesn't supprot 5.x anymore.

I don't know of any 7.2 errors or warnings. I have been running Matomo with 7.2 for a long time and didn't see any. If you are experiencing warnings, please report them, so they can be fixed.

@J0WI
Copy link
Author

J0WI commented Jan 23, 2019

I didn't use PHP 7.2 before #13272. I updated PHP for Matomo 3.8.0 in the Docker image: matomo-org/docker@15c48db
But I think it's bad to ship with PHP 7.3 by default while there are still warnings.

@Findus23
Copy link
Member

Now with 3.8.1 all PHP 7.3 bugs should be fixed (unless someone finds a new one)

@Findus23 Findus23 added the answered For when a question was asked and we referred to forum or answered it. label Jan 29, 2019
@J0WI
Copy link
Author

J0WI commented Jan 29, 2019

unless someone finds a new one

This risk could be reduced by adding PHP 7.3 to Travis CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
answered For when a question was asked and we referred to forum or answered it.
Projects
None yet
Development

No branches or pull requests

2 participants