Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't cache tag manager preview files #13977

Merged
merged 2 commits into from Jan 21, 2019
Merged

Don't cache tag manager preview files #13977

merged 2 commits into from Jan 21, 2019

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Jan 18, 2019

Not sure if this will work across apache versions? Tested on Apache 2.2

Prevents preview files from being cached in the browser and that always the newest version will be served. Otherwise the user will need to use ctrl+r or something to reload a page that includes a preview file to make sure the cache is ignored and many users would not know that.

refs matomo-org/tag-manager#150
for Nginx see matomo-org/matomo-nginx#48

Not sure if this will work across apache versions? Tested on Apache 2.2

Prevents preview files from being cached in the browser and that always the newest version will be served.

refs matomo-org/tag-manager#150
@diosmosis
Copy link
Member

Tested locally, it works on apache 2.4, however I had one problem. If mod_headers isn't enabled, apache will just issue 500 errors (for everything in the folder, not just preview JS files).

@tsteur
Copy link
Member Author

tsteur commented Jan 21, 2019

can you check if that works?

@diosmosis
Copy link
Member

👍 works

@diosmosis diosmosis merged commit 3dce94b into 3.x-dev Jan 21, 2019
@diosmosis diosmosis deleted the previewnocache branch January 21, 2019 23:32
@mattab mattab modified the milestones: 3.9.0, 3.8.1 Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants