…display notification if empty report and archiving has not been run recently.
The notification won't be displayed with the segment notification in order to avoid confusion.
Looks good :+1:
Could we move the new diagnostic just below the other archive related diagnostic?
There might be an edge case, if someone sets up an archiving job, which only archives a specific site. But not sure if it's worth to solve that.
Not needed to deal with this case, we can for now assume the crontab is setup correctly :+1:
Also would it be maybe possible to have a UI test showing the report footer message?
Actually maybe adding UI tests for these kind of features is not a good idea as it would be bloated if we test everything in this way....
-> Could we maybe instead add an integration test that checks the output of the report contains our footer message?
Could we maybe instead add an integration test that checks the output of the report contains our footer message?
@mattab it's actually in a notification, should it be a footer message in the report? Note: this will be added to every report, so you'll see the footer message everywhere, as opposed to a single notification.
Notification sounds better 👍