Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply AddSegmentBySegmentValue filter recursive #13962

Merged
merged 1 commit into from Jan 21, 2019
Merged

Apply AddSegmentBySegmentValue filter recursive #13962

merged 1 commit into from Jan 21, 2019

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jan 14, 2019

When a datatable is loaded expanded the segmentValue metadata won't be converted into segment metadata for all subtables. This is also the case when search in action subtables as described in #11849.

fixes #11849

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Jan 14, 2019
@sgiehl sgiehl added this to the 3.9.0 milestone Jan 14, 2019
diosmosis
diosmosis approved these changes Jan 14, 2019
View reviewed changes
Copy link
Member

@diosmosis diosmosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests need an update, otherwise looks good

@diosmosis diosmosis merged commit 14ccca8 into 3.x-dev Jan 21, 2019
@diosmosis diosmosis deleted the fix11849 branch January 21, 2019 23:47
@mattab mattab modified the milestones: 3.9.0, 3.8.1 Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diosmosis diosmosis diosmosis approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.8.1
Development

Successfully merging this pull request may close these issues.

Segmented Visitor Log icon does not show in Actions > Pages report in sub-tables, when a search is being done
3 participants
@sgiehl @diosmosis @mattab